[Unity][TVMScript] Parse R.Object return type from call_pure_packed #16593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `R.call_packed` and `R.call_pure_packed` had different normalization for the `sinfo_args` argument. While `R.call_packed` checked if the struct info needed to be converted using `ObjectGeneric.asobject()`, `R.call_pure_packed` did not. This commit updates the `R.call_pure_packed` to handle `sinfo_args` in the same manner as `R.call_packed`.
Hzfengsy
approved these changes
Feb 19, 2024
Lunderberg
deleted the
tvmscript_handle_object_generic_in_call_pure_packed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
R.call_packedandR.call_pure_packedhad different normalization for thesinfo_argsargument. WhileR.call_packedchecked if the struct info needed to be converted usingObjectGeneric.asobject(),R.call_pure_packeddid not.This commit updates the
R.call_pure_packedto handlesinfo_argsin the same manner asR.call_packed.