[KVCache] Fix the reference counter in sequence fork #16666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a sequence reference counter bug in the KV cache: when forking a child sequnece from an existing parent sequence, the reference counter of hte parent sequence was not increased. This leads to error when the child sequence is removed, where we will check the parent's reference counter and find it is 0 and is never changed unexpectedly. Meanwhile, this PR updates the PagedKVCache tests with some latest changes, including target-aware tile size selection.
Contributor
Author
|
@tvm-bot rerun |
5 similar comments
Contributor
Author
|
@tvm-bot rerun |
Member
|
@tvm-bot rerun |
Contributor
Author
|
@tvm-bot rerun |
Contributor
Author
|
@tvm-bot rerun |
Contributor
Author
|
@tvm-bot rerun |
tqchen
approved these changes
Mar 4, 2024
Lunderberg
pushed a commit
to Lunderberg/tvm
that referenced
this pull request
Mar 12, 2024
This PR fixes a sequence reference counter bug in the KV cache: when forking a child sequnece from an existing parent sequence, the reference counter of hte parent sequence was not increased. This leads to error when the child sequence is removed, where we will check the parent's reference counter and find it is 0 and is never changed unexpectedly. Meanwhile, this PR updates the PagedKVCache tests with some latest changes, including target-aware tile size selection.
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
This PR fixes a sequence reference counter bug in the KV cache: when forking a child sequnece from an existing parent sequence, the reference counter of hte parent sequence was not increased. This leads to error when the child sequence is removed, where we will check the parent's reference counter and find it is 0 and is never changed unexpectedly. Meanwhile, this PR updates the PagedKVCache tests with some latest changes, including target-aware tile size selection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a sequence reference counter bug in the KV cache: when forking a child sequnece from an existing parent sequence, the reference counter of hte parent sequence was not increased. This leads to error when the child sequence is removed, where we will check the parent's reference counter and find it is 0 and is never changed unexpectedly.
Meanwhile, this PR updates the PagedKVCache tests with some latest changes, including target-aware tile size selection.