[Contrib] Support NDArray cache taking generator #16693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterJH5574
force-pushed
the
tvm-dev/2024-03-09-ndcache-generator
branch
from
9a5dccb to
4a9e986
Compare
tqchen
reviewed
Mar 9, 2024
Member
tqchen
left a comment
tqchen
left a comment
There was a problem hiding this comment.
some minor nitsm otherwise LGTM
This PR enhances the `dump_ndarray_cache` function to take generator as input. Previously it can only take a dictionary. Sometimes, it is possible that the total ndarray size cannot fit the main CPU memory, in which case we may turn to using generators so we can free some NDArray memory on the fly. And this PR supports the NDArray cache dumping with generators.
MasterJH5574
force-pushed
the
tvm-dev/2024-03-09-ndcache-generator
branch
from
4a9e986 to
16a83c8
Compare
tqchen
approved these changes
Mar 9, 2024
Lunderberg
pushed a commit
to Lunderberg/tvm
that referenced
this pull request
Mar 12, 2024
This PR enhances the `dump_ndarray_cache` function to take generator as input. Previously it can only take a dictionary. Sometimes, it is possible that the total ndarray size cannot fit the main CPU memory, in which case we may turn to using generators so we can free some NDArray memory on the fly. And this PR supports the NDArray cache dumping with generators.
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
This PR enhances the `dump_ndarray_cache` function to take generator as input. Previously it can only take a dictionary. Sometimes, it is possible that the total ndarray size cannot fit the main CPU memory, in which case we may turn to using generators so we can free some NDArray memory on the fly. And this PR supports the NDArray cache dumping with generators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
dump_ndarray_cachefunction to take generator as input. Previously it can only take a dictionary.Sometimes, it is possible that the total ndarray size cannot fit the main CPU memory, in which case we may turn to using generators so we can free some NDArray memory on the fly. And this PR supports the NDArray cache dumping with generators.