[Analysis] Allow calls to GlobalVar in @R.function #16778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the post-parsing well-formed check performed by TVMScript allowed a call to `GlobalVar` in a `@R.function`, but only if it occurred within the context of a `@I.ir_module`. If `@R.function` appeared on its own, calls to a `GlobalVar` would be treated as calls to an undefined function.
Lunderberg
force-pushed
the
analysis_global_var_in_bare_relax_function
branch
from
013848e to
25a0e31
Compare
slyubomirsky
approved these changes
Mar 25, 2024
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
This is an interesting case, one that did not occur to me. I think it's fine to have a separate rule for analyzing a standalone function compared to an entire module. The restructuring also cleans up some of the code in the parser, so I'm for it.
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
* [Analysis] Allow calls to GlobalVar in @R.function Prior to this commit, the post-parsing well-formed check performed by TVMScript allowed a call to `GlobalVar` in a `@R.function`, but only if it occurred within the context of a `@I.ir_module`. If `@R.function` appeared on its own, calls to a `GlobalVar` would be treated as calls to an undefined function. * Use approrpirate well-formed checks TIR/Relax functions * Lint fix * Import order fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the post-parsing well-formed check performed by TVMScript allowed a call to
GlobalVarin a@R.function, but only if it occurred within the context of a@I.ir_module. If@R.functionappeared on its own, calls to aGlobalVarwould be treated as calls to an undefined function.