[OpenCL] Add OpenCL device for automatic target detection #16854
Conversation
|
Please, add CI tests. |
mengshyu
changed the title
mengshyu
force-pushed
the
main
branch
2 times, most recently
from
0207627 to
547140c
Compare
| def _detect_opencl(dev: Device) -> Target: | ||
| return Target( | ||
| { | ||
| "kind": "opencl", |
There was a problem hiding this comment.
In some cases, we can initialize OpenCL target with specifying specific device, e.g.:
target = Target("opencl -device=mali", host="llvm -mtriple=aarch64-linux-gnu")
or
target = Target("opencl -device=adreno", host="llvm -mtriple=arm64-linux-android")
Can we handle these cases somehow?
There was a problem hiding this comment.
Yes, I have verified on Orange Pi.
There was a problem hiding this comment.
Sorry, probably my question wasn't clear. Yes, I know that we can get such information from target. But I'm curious if we can get this information from the device somehow?
Probably, we can specify by an addition parameter to Target.from_device(input_device). For example: Target.from_device(input_device, '-device=adreno') will specify target as "kind": "opencl -device=adreno". Does it make sense?
There was a problem hiding this comment.
It seems there is no argument for '-device=adreno' in API Target.from_device.
This PR intends to fix weight conversion for MLC LLM on OrangePi (#1557), assuming there are no other issues. I would like to merge it first. If you have any suggestions, perhaps we can create another issue to discuss. Thanks.
This PR adds OpenCL device for automatic target detection.
Hi @echuraev |
echuraev
left a comment
echuraev
left a comment
There was a problem hiding this comment.
In general LGTM. Thanks!
3 participants
This PR adds OpenCL device for automatic target detection