[QoL][Relax] Infer StructInfo for relax::Tuple on construction #16860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `relax::Tuple` constructor left the `struct_info_` field undefined. This is inconsistent with other Relax leaf nodes, such as `relax::PrimValue`, `relax::Constant`, and `relax::ExternFunc`, which initialize their struct info on construction. This commit updates the `relax::Tuple` constructor to define `struct_info_` as `TupleStructInfo`, if all fields have a known struct info. If any field does not have a known struct info, the current behavior is kept, where `struct_info_` is constructed as `NullOpt`, and is later populated by the `relax::BlockBuilder`.
vinx13
approved these changes
Apr 16, 2024
Lunderberg
deleted the
relax_qol_infer_tuple_struct_info_on_construction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
relax::Tupleconstructor left thestruct_info_field undefined. This is inconsistent with other Relax leaf nodes, such asrelax::PrimValue,relax::Constant, andrelax::ExternFunc, which initialize their struct info on construction.This commit updates the
relax::Tupleconstructor to definestruct_info_asTupleStructInfo, if all fields have a known struct info. If any field does not have a known struct info, the current behavior is kept, wherestruct_info_is constructed asNullOpt, and is later populated by therelax::BlockBuilder.