[CUBLAS] Set fp32 compute and scale dtypes in fp16 matmul #16892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces fp16 compute dtype and scale dtype by fp32 in cublas matmul.
According to cuBLAS docs there are two possible options for compute/scale dtype when input/output dtype is fp16:
fp16and scale dtype isfp16fp32and scale dtype isfp32By default, we use 1) in apache/tvm and 2) in octoml/tvm. This commit aligns different behaviour and set
fp32as default.cc @vinx13 @masahi