Skip to content

Conversation

@Lunderberg
Copy link
Contributor

The github macOS-latest tag is updating from macOS-12 to macOS-14 (github changelog). While the macOS-12 environment provided miniconda by default, the macOS-14 environment does not (default installations for macOS-12 and for macOS-14). This is causing spurious failures across several PRs, as no base environment is found (CI links to recent examples: link, link, link).

This commit is a temporary fix, replacing the macOS-latest tag with macOS-12.

The github `macOS-latest` tag is updating from `macOS-12` to
`macOS-14` ([github
changelog](https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image/)).
While the `macOS-12` environment provided miniconda by default, the
`macOS-14` environment does not (default installations for
[`macOS-12`](https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md)
and for
[`macOS-14`](https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md)).
This is causing spurious failures across several PRs, as no base
environment is found (CI links to recent examples:
[link](https://github.com/apache/tvm/actions/runs/8860158060/job/24330642411?pr=16940#step:3:40),
[link](https://github.com/apache/tvm/actions/runs/8860112927/job/24330555555?pr=16938#step:3:40),
[link](https://github.com/apache/tvm/actions/runs/8852983771/job/24330650551?pr=16930#step:3:40)).

This commit is a temporary fix, replacing the `macOS-latest` tag with
`macOS-12`.
Copy link
Contributor

@quic-sanirudh quic-sanirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this. A lot of PRs are affected by this right now. Just out of curiosity, is there any way to re-trigger them all together, or should the authors just manually tag tvm-bot to rerun CI in each PR individually.

@Lunderberg
Copy link
Contributor Author

Thanks a lot for this. A lot of PRs are affected by this right now.

No problem! I was running into the same issue across several of my open PRs, which made me guess that it was something more widespread than any individual change.

Just out of curiosity, is there any way to re-trigger them all together, or should the authors just manually tag tvm-bot to rerun CI in each PR individually.

Unfortunately, nothing that I'm aware of. It would be nice to trigger them all, so that the CI backlog might be cleared out by Monday.

Though, the tvm-bot tagging can be done by somebody other than the PR author, so I might go through the recent PRs and re-trigger them manually.

@tqchen
Copy link
Member

tqchen commented Apr 27, 2024

#16942 might help

@tqchen
Copy link
Member

tqchen commented Apr 27, 2024

note that macos is not madantory, so we can still merge pr with this

@Lunderberg
Copy link
Contributor Author

Good point on the MacOSX CI not being required. In case anybody else runs into it, it looks like the individual step is marked as failing, the PR as a whole is marked as failing, and the background of the "Squash and Merge" button is greyed out, but the text of the button isn't greyed out.

image

Thank you for pointing out #16942, and I like it more than this PR as it solves the long-term compatibility issue. I'll leave this PR open until #16942 lands, in case we end up needing it.

@tqchen tqchen closed this Apr 29, 2024
@tqchen
Copy link
Member

tqchen commented Apr 29, 2024

#16942 now lands and fixed the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants