[Relax][Transform] Handle identical PrimFunc with distinct VDevice #16959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if an `IRModule` contained two expressions, where the types of the arguments differed only by the `VDevice`, these would be legalized to produce a single PrimFunc. This PrimFunc would have the a `tvm::attr::kTarget` annotation specific to one of those expressions, and would be incorrect for use in the other location. This commit updates the `LegalizeOps` transform to handle this case, producing multiple TIR PrimFuncs if required by the `VDevice` annotations.
Lunderberg
force-pushed
the
relax_legalize_primfuncs_with_vdevice
branch
from
2d7e065 to
2bc7f47
Compare
Contributor
Author
|
CI is stalled on Restarting CI to see if it resolves the issue. |
Contributor
Author
|
@tvm-bot rerun |
masahi
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if an
IRModulecontained two expressions, where the types of the arguments differed only by theVDevice, these would be legalized to produce a single PrimFunc. This PrimFunc would have the atvm::attr::kTargetannotation specific to one of those expressions, and would be incorrect for use in the other location.This commit updates the
LegalizeOpstransform to handle this case, producing multiple TIR PrimFuncs if required by theVDeviceannotations.