[Relax][Bugfix] Annotate ComputePrimValue output as host function #17032
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ComputePrimValue` transform is used to compute the value of symbolic expressions that may appear within a Relax function. For example, to compute a boolean condition used for a `relax::If` node. These functions are used for small host-side computations, prior to launching a device kernel. This commit updates `ComputePrimValue` to annotate the generated `PrimFunc` with `tir::attr::kIsHostFunc`. This annotation is required for correct behavior in `tvm.dlight.ApplyDefaultSchedule`, to avoid erroneous scheduling of this function for the GPU, and for `tir::transform::BindTarget`, to ensure that the function is compiled for execution on the host. Co-authored-by: Chris Sullivan <[email protected]>
Contributor
Author
|
This PR is identical to the now-closed PR #17024, as a CI restart prevented the CI from running on the original PR. |
tqchen
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ComputePrimValuetransform is used to compute the value of symbolic expressions that may appear within a Relax function. For example, to compute a boolean condition used for arelax::Ifnode. These functions are used for small host-side computations, prior to launching a device kernel.This commit updates
ComputePrimValueto annotate the generatedPrimFuncwithtir::attr::kIsHostFunc. This annotation is required for correct behavior intvm.dlight.ApplyDefaultSchedule, to avoid erroneous scheduling of this function for the GPU, and fortir::transform::BindTarget, to ensure that the function is compiled for execution on the host.