[Arith][SVE] Add rewrite rules for indices split by scalable expressions #17046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekalda
reviewed
May 30, 2024
Contributor
|
cc @Lunderberg |
ekalda
approved these changes
May 31, 2024
Contributor
ekalda
left a comment
ekalda
left a comment
There was a problem hiding this comment.
Thanks for cleaning it up @Anndrey24! I'm a bit surprised by how permissive the rewrite rules have been towards division by zero, I hope I'm not missing something there. Let's see what the CI does, I hope the stack isn't relying on that behaviour too much 🙈
This commit introduces rewrite rules for indices which can arise from splitting axes by scalable factors (e.g. `xo, xi = sch.split(x, factors = [None, 8 * T.vscale()])`):
```
(v_x_o * T.Cast("int64", T.vscale()) * T.int64(8) + v_x_i) // (T.Cast("int64", T.vscale()) * T.int64(8)) == v_x_o
(v_x_o * T.Cast("int64", T.vscale()) * T.int64(8) + v_x_i) % (T.Cast("int64", T.vscale()) * T.int64(8)) == v_x_i
```
The rewrites help prove checks needed by `sch.tensorize()` (e.g. CompareBufferRegion).
Anndrey24
force-pushed
the
vscale-rewrite-simplify
branch
from
e351cbc to
bf66ecd
Compare
Contributor
|
We decided to roll back to the initial version of this patch since a large number of Relax tests fail when division by zero is disabled in the rewrite rules (so dealing with this is out of scope for this patch). |
Contributor
|
Thanks @Anndrey24! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces rewrite rules for indices which can arise from splitting axes by scalable factors (e.g.
xo, xi = sch.split(x, factors = [None, 8 * T.vscale()])):The rewrites help prove checks needed by
sch.tensorize()(e.g. CompareBufferRegion).cc @ekalda @lhutton1