[Bugfix] Update FAttrsGetter to return Map<String, ObjectRef> #17096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `FAttrsGetter` was defined as a function that returned `Map<String, String>`. However, it is used to define attributes in a `Map<String, ObjectRef>`, and in some cases is used to define attributes whose value is a dictionary (e.g. `msc_attrs_getter` in `python/tvm/contrib/msc/core/transform/pattern.py`). This commit updates the type signature of `FAttrsGetter` to match its usage, returning a `Map<String, ObjectRef>`.
Contributor
Author
|
This change is split out from #16183 as an independent change for ease of review. |
yongwww
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
FAttrsGetterwas defined as a function that returnedMap<String, String>. However, it is used to define attributes in aMap<String, ObjectRef>, and in some cases is used to define attributes whose value is a dictionary (e.g.msc_attrs_getterinpython/tvm/contrib/msc/core/transform/pattern.py).This commit updates the type signature of
FAttrsGetterto match its usage, returning aMap<String, ObjectRef>.