[TIR][RPC] Allow RPC calls to compiled PrimFuncs with no arguments #17098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `PackedFunc` interface has arguments `int num_args` and `TVMValue* args`, which contain the number of arguments and a pointer to the array of arguments. Prior to this commit, when implementing the `PackedFunc` interface for TIR `PrimFunc`s, the `MakePackedAPI` pass would always assert that the `args` pointer was not null. However, the `args` pointer is allowed to be null if `num_args` is zero. For example, this occurs when calling an RPC function with no arguments. This commit updates the `MakePackedAPI` transform to only assert that `args` is non-null when `num_args` is greater than zero.
tqchen
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PackedFuncinterface has argumentsint num_argsandTVMValue* args, which contain the number of arguments and a pointer to the array of arguments. Prior to this commit, when implementing thePackedFuncinterface for TIRPrimFuncs, theMakePackedAPIpass would always assert that theargspointer was not null. However, theargspointer is allowed to be null ifnum_argsis zero. For example, this occurs when calling an RPC function with no arguments.This commit updates the
MakePackedAPItransform to only assert thatargsis non-null whennum_argsis greater than zero.