-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Hexagon] [CMake] Fix v66 build issue #17169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hexagon] [CMake] Fix v66 build issue #17169
Conversation
with SDK4.5 and added your modifications about the cmake file, building errors like this: Hexagon_SDK_4_5/libs/qhl_hvx/inc/internal/qhmath_hvx_vector.h:837:66: error: use of undeclared identifier 'Q6_Vsf_equals_Vqf32' |
|
after adding the following cmake modification: building succeed! |
Right, the problem is that Starting 4.0, Hexagon SDK supports v68, so v68 libraries are also included in QHL_HVX libs. Excluding just the files not supported for v68 when we mention a lower architecture is a problem because the exact files that need to be excluded changes with each Hexagon SDK release. The best way is to just use Hexagon SDK 3.5 which is the last version that does not have v68 support and so it should work without any change. Or the other option is to pass |
5fc90d0 to
b2ab420
Compare
|
@tvm-bot rerun |
This patch fixes the issue mentioned in [apache#17163](apache#17163)
b2ab420 to
772a9ca
Compare
abhikran-quic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @quic-sanirudh!
This patch fixes the issue mentioned in #17163.
The issue was because some files that are built into the runtime depend on architecture features that are only available starting from v68. Hence, we should not link them into the runtime if the architecture mentioned is v66 or v65.