[Disco] Implement SocketSession #17182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
force-pushed
the
feat/disco-socket
branch
from
c44798d to
73bf90a
Compare
Comment on lines
72
to
75
| /*! \brief The local worker id. This can be different from `worker_id` if the session is | ||
| * consisted of multiple distritributed sub-sessions. | ||
| */ | ||
| int local_worker_id; |
Contributor
There was a problem hiding this comment.
We introduced int num_groups in #17180 which causes some conflicts. local_worker_id now equals to worker_id % (num_workers / num_groups).
Implements SocketSession that connects multiple local worker processes/threads over multiple distributed nodes via TCP socket.
vinx13
force-pushed
the
feat/disco-socket
branch
from
f244f4c to
bdf0ca4
Compare
tqchen
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements SocketSession that connects multiple local worker processes/threads over multiple distributed nodes via TCP socket.
cc @tqchen @cyx-6