[Web] Add TVMArgBool to ArgTypeCode #17251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieFRuan
commented
Aug 7, 2024
| case ArgTypeCode.Int: | ||
| case ArgTypeCode.UInt: | ||
| case ArgTypeCode.TVMArgBool: | ||
| return this.memory.loadI64(rvaluePtr); |
Member
|
temp block this in light of #16183 (comment) |
Contributor
|
#17240 has now landed, so this PR should be able to be revisited. |
tqchen
approved these changes
Aug 23, 2024
CharlieFRuan
added a commit
to mlc-ai/web-llm
that referenced
this pull request
Aug 23, 2024
### Change - #555 ### TVMjs - Updated to current head: apache/tvm@1518008 - Main change is apache/tvm#17251 - This is needed for WASMs compiled after apache/tvm#17257 is merged (e.g. Phi-3.5). TVM global functions that returns bool need this PR to run correctly (e.g. `AcceptToken()` in BNFGrammar) in runtime. - However, these are backward compatible to WASMs compiled prior to this PR. Tested with Phi-3 (old WASM) running grammar.
jingyi-zhao-01
pushed a commit
to jingyi-zhao-01/web-llm
that referenced
this pull request
Dec 8, 2024
### Change - mlc-ai#555 ### TVMjs - Updated to current head: apache/tvm@1518008 - Main change is apache/tvm#17251 - This is needed for WASMs compiled after apache/tvm#17257 is merged (e.g. Phi-3.5). TVM global functions that returns bool need this PR to run correctly (e.g. `AcceptToken()` in BNFGrammar) in runtime. - However, these are backward compatible to WASMs compiled prior to this PR. Tested with Phi-3 (old WASM) running grammar.
atebites-hub
pushed a commit
to atebites-hub/web-llm
that referenced
this pull request
Oct 4, 2025
### Change - mlc-ai#555 ### TVMjs - Updated to current head: apache/tvm@1518008 - Main change is apache/tvm#17251 - This is needed for WASMs compiled after apache/tvm#17257 is merged (e.g. Phi-3.5). TVM global functions that returns bool need this PR to run correctly (e.g. `AcceptToken()` in BNFGrammar) in runtime. - However, these are backward compatible to WASMs compiled prior to this PR. Tested with Phi-3 (old WASM) running grammar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent PR #16183,
TVMArgTypeCodeintroducedTVMArgBool. This PR is needed for the web runtime when a TVM packed function returns a bool.