[Rust] Remove mxnet dependency and re-enable rust example #17293
+16
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshr-h
changed the title
mshr-h
changed the title
mshr-h
force-pushed
the
remove-mxnet-from-rust-example
branch
3 times, most recently
from
454db97 to
1ede00b
Compare
This was referenced Aug 23, 2024
mshr-h
force-pushed
the
remove-mxnet-from-rust-example
branch
from
1ede00b to
24d118f
Compare
Hzfengsy
approved these changes
Aug 30, 2024
Contributor
|
I am not an official reviewer, but to me it looks very good. |
yongwww
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace mxnet's resnet18 with torchvision.
Clean up import statements in
rust/tvm/examples/resnet/src/build_resnet.py.Related PR and Issue:
cc: @Hzfengsy @tqchen @cgerum