Skip to content

[Disco] Enable float8 data type in disco #17398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2024
Merged

[Disco] Enable float8 data type in disco #17398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/runtime/disco/nccl/nccl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,12 @@ void AllReduce(NDArray send, ReduceKind reduce_kind, bool in_group, NDArray recv
ShapeTuple shape = send.Shape();
int64_t numel = shape->Product();
deviceStream_t stream = ctx->GetDefaultStream();
DataType dtype = DataType(send->dtype);
if (dtype == DataType::NVFloat8E4M3() || dtype == DataType::NVFloat8E5M2()) {
LOG(FATAL) << "Float8 data type cannot be allreduced, as nccl does not support this data type.";
}
NCCL_CALL(ncclAllReduce(send->data, recv->data, numel,
/*datatype=*/AsNCCLDataType(DataType(send->dtype)),
/*datatype=*/AsNCCLDataType(dtype),
/*op=*/AsNCCLRedOp(reduce_kind),
in_group ? ctx->group_comm : ctx->global_comm, stream));
}
Expand Down
5 changes: 4 additions & 1 deletion src/runtime/disco/nccl/nccl_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ inline ncclDataType_t AsNCCLDataType(runtime::DataType dtype) {
if (dtype == DataType::Int(8)) {
return ncclInt8;
}
if (dtype == DataType::UInt(8)) {
if (dtype == DataType::UInt(8) || dtype == DataType::NVFloat8E4M3() ||
dtype == DataType::NVFloat8E5M2()) {
// For float8 data type, pretend to be uint8 in nccl.
// And will throw error when allreduce, as it makes no sense in this case.
return ncclUint8;
}
if (dtype == DataType::Int(32)) {
Expand Down