Skip to content

[Web] Allow deprecated API requestAdapterInfo with any cast #17420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2024
Merged

[Web] Allow deprecated API requestAdapterInfo with any cast #17420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c5215e
[Web] Allow deprectaed API with any cast
CharlieFRuan Sep 26, 2024
5d769ed
Fix lint
CharlieFRuan Sep 26, 2024
58d0f4d
Fix by adding await
CharlieFRuan Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "TVM WASM/WebGPU runtime for JS/TS",
"license": "Apache-2.0",
"homepage": "https://github.com/apache/tvm/tree/main/web",
"version": "0.18.0-dev0",
"version": "0.18.0-dev2",
"files": [
"lib"
],
Expand Down
4 changes: 3 additions & 1 deletion web/src/webgpu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ export async function detectGPUDevice(): Promise<GPUDeviceDetectOutput | undefin
requiredFeatures.push("shader-f16");
}

const adapterInfo = adapter.info;
// requestAdapterInfo() is deprecated, causing requestAdapterInfo to raise
// issue when building. However, it is still needed for older browsers, hence `as any`.
const adapterInfo = adapter.info || await (adapter as any).requestAdapterInfo();
const device = await adapter.requestDevice({
requiredLimits: {
maxBufferSize: requiredMaxBufferSize,
Expand Down
Loading