Skip to content

Conversation

@agoston-mc
Copy link
Contributor

As per apache/tvm-rfcs#108 and #17053 this PR is to update the Docker images to include the NNEF and NNEF-Tools packages.

@mshr-h
Copy link
Contributor

mshr-h commented Oct 2, 2024

Please rebase it from main.
The ci_riscv build error is caused by the recent commit in risc-v-pk repo. It's fix by pinning the commit id on #17425.

https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-docker/detail/PR-17433/1/pipeline

[2024-10-01T15:02:50.101Z] 79.34 ../pk/pk.c: Assembler messages:
[2024-10-01T15:02:50.101Z] 79.34 ../pk/pk.c:122: Error: unknown CSR `ssp'
[2024-10-01T15:02:50.101Z] 79.34 make: *** [Makefile:336: pk.o] Error 1
[2024-10-01T15:02:50.101Z] 79.34 make: *** Waiting for unfinished jobs....

@mshr-h mshr-h self-assigned this Oct 2, 2024
@mshr-h
Copy link
Contributor

mshr-h commented Oct 3, 2024

Overall looks good to me! Just a minor change is needed.

@mshr-h mshr-h merged commit ba0881e into apache:main Oct 4, 2024
19 of 20 checks passed
@agoston-mc
Copy link
Contributor Author

Hi,
During the refactor, with c81fcca, these changes were reverted, while NNEF would be a Relax frontend as well. Can I ask for these changes to be restored, so I can push ahead with #17053?
@mshr-h @tqchen @Hzfengsy

@tqchen
Copy link
Member

tqchen commented May 10, 2025

Sorry about that, do mind you send a new PR to reintroduce those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants