[Marvell BYOC]: global_max_pool2d and squeeze op support #17481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please review cc @Hzfengsy |
Member
|
The changes look good to me. However, the whole community is moving towards the Relax approach instead of the legacy Relay workflow. And the relay flow might be deprecated in some time. I hope you can try migrating to Relax flow :) |
Hzfengsy
approved these changes
Oct 24, 2024
Contributor
Author
|
@Hzfengsy Thank you for your feedback and approval of the changes. I appreciate the heads-up regarding the community's transition towards the Relax approach. We are also planning to migrate from the Relay workflow to Relax in the near future. Could you kindly point me towards any transition guide or resources that would assist in making this shift smoother? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for global_max_pool2d and squeeze op for Marvell BYOC.
Also added unit tests for Maxpool, Avgpool, Global AvgPool, Global Maxpool and Squeeze operators