Skip to content

Conversation

@parsifal-47
Copy link
Contributor

Hello All,
this PR adapts for LLVM-20 changes. Please feel free to let me know if there is a better way to do it.
Thank you!

@cbalint13
Copy link
Contributor

Thank you @parsifal-47 !

This fix is welcome, it looks good to me.

Copy link
Contributor

@cbalint13 cbalint13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cbalint13 cbalint13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for previous rushed approval, I tested the proposal on my local and found these.

@parsifal-47
Copy link
Contributor Author

absolutely no problem @cbalint13 , let me fix the follow-ups and get back to you!

@parsifal-47
Copy link
Contributor Author

Apologies for previous rushed approval, I tested the proposal on my local and found these.

no problem, I have resolved all deprecation warnings, but I am not very confident about llvmGetPointerTo macro, let me know what you think, thank you!

Copy link
Contributor

@cbalint13 cbalint13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this really handles all the warnings for deprecation.

@cbalint13
Copy link
Contributor

@parsifal-47 , thank you for the work !
Let's further make sure all the CI tasks are in green to be able to merge it.

@cbalint13 cbalint13 changed the title Make compilable with LLVM-20 [LLVM] Make compilable with LLVM-20 Nov 30, 2024
@cbalint13 cbalint13 merged commit 513c2be into apache:main Dec 2, 2024
18 checks passed
ShiboXing pushed a commit to ShiboXing/tvm that referenced this pull request Aug 10, 2025
* [LLVM] Make compilable with LLVM-20

---------

Co-authored-by: Renat Idrisov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants