Skip to content

Conversation

@yongwww
Copy link
Member

@yongwww yongwww commented Feb 25, 2025

Update the CI Docker images to the latest built versions, and the torch gpu is supposed to be installed on gpu container.

cc: @MasterJH5574 @tqchen @mshr-h

@mshr-h
Copy link
Contributor

mshr-h commented Feb 26, 2025

The unity errors are caused by the changes in the Core Aten IR in PyTorch. https://github.com/pytorch/pytorch/releases/tag/v2.6.0
The temporal solution would be to go back to torch==2.4.1.

@MasterJH5574
Copy link
Contributor

Just a random thought: could we have different expected IRModules for different torch versions? Since torch version is available by torch.__version__, I'm wondering whether providing different expected IRModules for different versions can enable a bit better compatibility.

@mshr-h
Copy link
Contributor

mshr-h commented Feb 26, 2025

Maybe it's possible to support multiple versions of torch in the test. But I don't think we need to do it since Core Aten Ops is under active development so we only support the latest one to reduce the maintenance cost.

@yongwww
Copy link
Member Author

yongwww commented Feb 26, 2025

@MasterJH5574 @mshr-h Thank you for the extremely helpful input! I’ve skipped several tests in this PR, and we can re-enable them in follow-up PRs. It would be great to unblock the Docker images in this PR.

@mshr-h mshr-h merged commit e1714ba into apache:main Feb 26, 2025
14 checks passed
@yongwww yongwww deleted the update-images branch February 26, 2025 17:35
ShiboXing pushed a commit to ShiboXing/tvm that referenced this pull request Aug 10, 2025
* [CI] update images to 20250225-035137-aeadc31c

* Skip e2e in ci

* Skip the incompatible tests

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants