[FFI] Introduce small string/bytes #18185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces small string support to the FFI system. When the string length fit into the space in TVMFFIAny (aka len(str) <= 7). We directly store the string content into the TVMFFIAny content instead of creating a Object. This change will likely speedup small string access. Some implications: - Always check for kTVMFFISmallStr code as well as kTVMFFIStr - Always check for kTVMFFISmallBytes when checking kTVMFFIBytes - Avoid using details::StringObj, instead, always use any.as<String>() - Always set any.padding to 0 for other values (in compiler and runtime) to enable fast cmp
Hzfengsy
approved these changes
Aug 4, 2025
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces small string support to the FFI system. When the string length fit into the space in TVMFFIAny (aka len(str) <= 7). We directly store the string content into the TVMFFIAny content instead of creating a Object. This change will likely speedup small string access.
Some implications: