[Fix] Codegen fix for relax cutlass #18190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
reviewed
Aug 6, 2025
| default_headers << "#include <cutlass/coord.h>\n"; | ||
| default_headers << "#include <cutlass/tensor_ref.h>\n"; | ||
| default_headers << "#include <cutlass/util/host_tensor.h>\n"; | ||
| default_headers << "#include <tvm/runtime/logging.h>\n"; |
Member
There was a problem hiding this comment.
To reduce overall dependency, assuming the codegen part did not use ICHECK or (or change to TVM_FFI_ICHECK), LOG(INFO), instead to #include <tvm/ffi/function.h> to minimize deps
Member
|
Thanks @jcf94 ! some minor nit |
Member
|
@jcf94 would be great to do the followup minor change and see if we can bring it in. thank you |
Contributor
Author
Sorry for just seeing your comment. 😂 |
tqchen
approved these changes
Aug 9, 2025
Member
|
Thanks @jcf94 I made a minor change and once it is green we can merge it in |
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
* Codegen fix --------- Co-authored-by: Tianqi Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the migration from TVMValue to PackedArgs/AnyView missed the codegen part when I tried to test relax cutlass.
With this fix, now the codegened cutlass .cu can pass nvcc compile.
BTW, the relax/cutlass part has not been guarded by CI?