[FFI] Fix system library symbol lookup #18298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a bug in the current system library symbol lookup. Prior to this PR, the lookup key always concatenates `symbol_prefix_` and `name`. However, the `name` may or may not have already contained the symbol prefix. And when it does contain the symbol prefix, the concantenated string will have duplicate symbol prefix, which leads to the lookup failure, because in the compiled library the symbol prefix only appears once. This PR changes the lookup behavior to check both cases.
mshr-h
approved these changes
Sep 10, 2025
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the current system library symbol lookup.
Prior to this PR, the lookup key always concatenates
symbol_prefix_andname. However, thenamemay or may not have already contained the symbol prefix. And when it does contain the symbol prefix, the concantenated string will have duplicate symbol prefix, which leads to the lookup failure, because in the compiled library the symbol prefix only appears once.This PR changes the lookup behavior to check both cases.