[Relay][Transform] merge PassContext and BuildConfig #3234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
May 23, 2019
tqchen
changed the title
tqchen
requested changes
May 24, 2019
tqchen
requested changes
May 24, 2019
tqchen
requested changes
May 24, 2019
zhiics
force-pushed
the
passcontext
branch
2 times, most recently
from
02e8dfb to
b62494c
Compare
tqchen
requested changes
May 24, 2019
Member
tqchen
left a comment
tqchen
left a comment
There was a problem hiding this comment.
please update again, the With PR is now in
tqchen
requested changes
May 24, 2019
tqchen
requested changes
May 24, 2019
tqchen
reviewed
May 24, 2019
tqchen
approved these changes
May 24, 2019
Member
|
Thanks @zhiics |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to:
BuildConfigandPassContextin both Python and C++ asBuildConfigis mainly used for managing pass configs. Python side is done. C++BuildConfigwill be replaced byPassContextwhen we start migratingoptimizeinbuild_modulewhich is the next task.withstatement where configs likeopt_levelanddisabled_passesare specified, as pointed out in [RFC][Relay] Pass API Discussion #3202SequentialAPI to supportwithsyntax.After this change, we should be able to test the given example once the passes are registered with
Pass MyPass(xxx).cc @tqchen @jroesch, @MarisaKirisame @wweic