[Relay] Strict mode in pattern matching #3620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Very good addition, thanks for doing it |
Contributor
|
Should the match completeness and the fatal stuff be the same PR, though? There are more issues where fatal is involved:
|
Contributor
Author
|
We'll do fatal next time |
Contributor
|
Thanks for removing fatal, I think this is in a good state now. |
slyubomirsky
approved these changes
Jul 31, 2019
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
A nitpick about the comments, but otherwise LGTM.
Co-Authored-By: Steven S. Lyubomirsky <[email protected]>
Co-Authored-By: Steven S. Lyubomirsky <[email protected]>
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Aug 9, 2019
* add fatal lint lint lint do make completeness check an error lint remove fatal * fix test * reset parser file * remove unneeded import * Update python/tvm/relay/adt.py Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Update include/tvm/relay/adt.h Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Eliminate trailing whitespace (my fault)
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
* add fatal lint lint lint do make completeness check an error lint remove fatal * fix test * reset parser file * remove unneeded import * Update python/tvm/relay/adt.py Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Update include/tvm/relay/adt.h Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Eliminate trailing whitespace (my fault)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the strict mode require that all pattern is exhausted. by default it is on, so one had to explicitly turn it off for hd, tl, foldl1, etc. This stop all the warning generated by the exhaust matcher, and enforce better coding style as partial function will be more explicit.