[PYTHON/FFI] Search PATH for DLLs #3888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
approved these changes
Sep 4, 2019
Member
|
Upon second thought, does it make sense to search the PATH for dynamically linked libraries? traditionally tools which link only search link paths, the PATH variable is intended to only be used for resolving executable names in shells. |
Contributor
Author
|
PATH is definitely used for executable names in general, but it seems like it's common to have libraries in there. For example, when you create an environment in Anaconda on Windows, However, if you're not comfortable with this change, I'm totally fine to close the PR. I just thought it would be a small quality-of-life change and make the runtime a little easier to distribute. |
MarisaKirisame
pushed a commit
to MarisaKirisame/tvm
that referenced
this pull request
Sep 7, 2019
* Search PATH for DLLs * Fix lint issue
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
* Search PATH for DLLs * Fix lint issue
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
* Search PATH for DLLs * Fix lint issue
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 16, 2019
* Search PATH for DLLs * Fix lint issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to search PATH for TVM DLLs.
@tqchen @Huyuwei would you be able to take a look?