Skip to content

[Relay] Fix match case in Python-side expr functor #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2019
Merged

[Relay] Fix match case in Python-side expr functor #4037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python/tvm/relay/expr_functor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,10 @@ def visit_constructor(self, con):
return con

def visit_match(self, m):
return Match(self.visit(m.data), [Clause(c.lhs, self.visit(c.rhs)) for c in m.clauses])
return Match(
self.visit(m.data),
[Clause(c.lhs, self.visit(c.rhs)) for c in m.clauses],
complete=m.complete)

def visit_ref_create(self, r):
return RefCreate(self.visit(r.value))
Expand Down
11 changes: 11 additions & 0 deletions tests/python/relay/test_expr_functor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,16 @@ def test_match():
p = relay.prelude.Prelude()
check_visit(p.mod[p.map])


def test_match_completeness():
p = relay.prelude.Prelude()
for completeness in [True, False]:
match_expr = relay.adt.Match(p.nil, [], complete=completeness)
result_expr = ExprMutator().visit(match_expr)
# ensure the mutator doesn't mangle the completeness flag
assert result_expr.complete == completeness


if __name__ == "__main__":
test_constant()
test_tuple()
Expand All @@ -139,3 +149,4 @@ def test_match():
test_ref_write()
test_memo()
test_match()
test_match_completeness()