[CMake] Imporve parameter 'ANTLR4' to avoid cmake will ignore the 'space'

[cchung100m]

Hi @KimBioInfoStudio, @MarisaKirisame @soiferj

Following the discussion Error while building TVM with USE_ANTLR and Relay from_tensorflow failed - Couldn’t find ANTLR parser, I found that FindANTLR.cmake cannot set ANTLR4 properly, therefore I add the double quotes to avoid the cmake ignores the "space" and cause an issue when executing -jar.

[cchung100m]

Hi

The issue is reported at PR [cmake][ANTLR] Support setting path to ANTLR jar, too.

[soiferj]

LGTM

[cchung100m]

Hi

This PR cannot pass the CI build process due to following issue, but I am not sure whether it is caused by this PR or not, I would appreciate if you can give me suggestions, thanks.

docker/bash.sh tvmai/ci-cpu:v0.54 ./tests/scripts/task_build.sh build -j2

[ 22%] Generating ../python/tvm/relay/grammar/py3/RelayVisitor.py, ../python/tvm/relay/grammar/py3/RelayParser.py, ../python/tvm/relay/grammar/py3/RelayLexer.py

/bin/sh: 1: /usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java -jar /usr/local/lib/antlr-4.7.1-complete.jar: not found

make[2]: *** [../python/tvm/relay/grammar/py3/RelayVisitor.py] Error 127

CMakeFiles/relay_parser.dir/build.make:62: recipe for target '../python/tvm/relay/grammar/py3/RelayVisitor.py' failed

CMakeFiles/Makefile2:660: recipe for target 'CMakeFiles/relay_parser.dir/all' failed

make[1]: *** [CMakeFiles/relay_parser.dir/all] Error 2

make[1]: *** Waiting for unfinished jobs....

[KimBioInfoStudio]

Hi

This PR cannot pass the CI build process due to following issue, but I am not sure whether it is caused by this PR or not, I would appreciate if you can give me suggestions, thanks.

docker/bash.sh tvmai/ci-cpu:v0.54 ./tests/scripts/task_build.sh build -j2

[ 22%] Generating ../python/tvm/relay/grammar/py3/RelayVisitor.py, ../python/tvm/relay/grammar/py3/RelayParser.py, ../python/tvm/relay/grammar/py3/RelayLexer.py

/bin/sh: 1: /usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java -jar /usr/local/lib/antlr-4.7.1-complete.jar: not found

make[2]: *** [../python/tvm/relay/grammar/py3/RelayVisitor.py] Error 127

CMakeFiles/relay_parser.dir/build.make:62: recipe for target '../python/tvm/relay/grammar/py3/RelayVisitor.py' failed

CMakeFiles/Makefile2:660: recipe for target 'CMakeFiles/relay_parser.dir/all' failed

make[1]: *** [CMakeFiles/relay_parser.dir/all] Error 2

make[1]: *** Waiting for unfinished jobs....

Hi @cchung100m only this problem only affect cmake func message( ), and @tqchen have fix this problem several days ago , so I think that you can close this PR now.
[CI] use llvm9 for the gpu tests #4224
CC : @soiferj what o u think , shoud we close this PR?