Skip to content

[RUNTIME] Enable hipModuleGetGlobal() in ROCm module #4321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2019
Merged

[RUNTIME] Enable hipModuleGetGlobal() in ROCm module #4321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/runtime/rocm/rocm_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,16 +122,9 @@ class ROCMModuleNode : public runtime::ModuleNode {
hipDeviceptr_t global = nullptr;
size_t nbytes = 0;

hipError_t result = hipSuccess;
// ROCM doesn't support hipModuleGetGlobal yet.
// hipError_t result = hipModuleGetGlobal(&global, &nbytes,
// module_[device_id], global_name.c_str());
ROCM_DRIVER_CALL(hipModuleGetGlobal(&global, &nbytes,
module_[device_id], global_name.c_str()));
CHECK_EQ(nbytes, expect_nbytes);
if (result != hipSuccess) {
LOG(FATAL)
<< "ROCMError: hipModuleGetGlobal " << global_name
<< " failed with error: " << hipGetErrorString(result);
}
return global;
}

Expand Down