Legalize - Use Non-recursive Rewriter. #5296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@mbrookhart can you help to review the PR |
masahi
reviewed
Apr 9, 2020
src/relay/transforms/legalize.cc
Outdated
| Expr Rewrite_(const CallNode* call_node, const Expr& post) override { | ||
| // Get the new_call node without any changes to current call node. | ||
| Expr new_e = ExprMutator::VisitExpr_(call_node); | ||
| Expr new_e = post; |
Member
There was a problem hiding this comment.
Can we just rename post to new_e and remove this line?
Contributor
Author
There was a problem hiding this comment.
I could not directly rename, as new_e was supposed to be the new expr and post is a cont. But, I have cleaned up the code, so that new_e is not needed anymore.
tmoreau89
approved these changes
Apr 9, 2020
Contributor
tmoreau89
left a comment
tmoreau89
left a comment
There was a problem hiding this comment.
great to see the non-recursive rewriter being used!
Member
|
@LiangHao151941 I think you could benefit this in your pr #4828 |
FrozenGene
approved these changes
Apr 10, 2020
Member
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* Legalize - Use Non-recursive Rewriter. * Cleanup.
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* Legalize - Use Non-recursive Rewriter. * Cleanup.
dpankratz
pushed a commit
to dpankratz/incubator-tvm
that referenced
this pull request
Apr 24, 2020
* Legalize - Use Non-recursive Rewriter. * Cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my pre-quantized model parsing was seeing segfault because of stack overflow. Switching to non-recursive mutation resolves the issue, and I can compile the model successfully. Thanks for this work!
@mbrookhart @tqchen