-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Torch] Support bincount and scatter_add ops #6740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
t-vi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the type for bincount would be good to improve, otherwise LGTM. Thank you @masahi
t-vi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @masahi.
decb436 to
c3e042f
Compare
|
Does the following code in |
|
Yes, bincount requires VM compile. |
|
I'm working on adding TF bincount support. I found that |
Add numpy style
bincountop converter by combinations of existing ops.https://pytorch.org/docs/stable/generated/torch.bincount.html
This is a part of supporting hummingbird project. Also add a
scatter_addop conversion, as requested.I hope performance would not be too bad, so that we don't have to implement a native
bincountop.please review @siju-samuel @t-vi
cc @interesaaat