[rust][tvm-graph-rt]: maintain error sources when propagating errors #6815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
approved these changes
Nov 2, 2020
… swap Mutex for RwLock
adelbertc
force-pushed
the
adel/tvm-graph-rt-cleanup
branch
from
76e4c4d to
a2804a3
Compare
imalsogreg
approved these changes
Nov 2, 2020
Contributor
imalsogreg
left a comment
imalsogreg
left a comment
There was a problem hiding this comment.
Nice looking cleanups.
jroesch
approved these changes
Nov 2, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
… swap Mutex for RwLock (apache#6815)
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
… swap Mutex for RwLock (apache#6815)
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
… swap Mutex for RwLock (apache#6815)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also swap
MutexforRwLockin syslib function registration (assuming reads are a lot more common than registration).cc @jroesch @imalsogreg @mwillsey @robo-corg