[TFLite] Added check for dynamic range quantization #7114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check to prevent optimized with "dynamic range quantization" tflite files to be loaded as the optimization is not fully supported. https://www.tensorflow.org/lite/performance/post_training_quantization#dynamic_range_quantization
giuseros
reviewed
Dec 16, 2020
giuseros
approved these changes
Dec 16, 2020
Contributor
giuseros
left a comment
giuseros
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments! LGTM now
Contributor
Author
|
@FrozenGene please, take a look |
Contributor
Author
|
How can we make progress here? |
Contributor
Author
FrozenGene
approved these changes
Feb 4, 2021
Member
|
Thanks @d-smirnov @d-smirnov merged now |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
* [TFLite] Added check for dynamic range quantization Added check to prevent optimized with "dynamic range quantization" tflite files to be loaded as the optimization is not fully supported. https://www.tensorflow.org/lite/performance/post_training_quantization#dynamic_range_quantization * linter * linter * unit test fix
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* [TFLite] Added check for dynamic range quantization Added check to prevent optimized with "dynamic range quantization" tflite files to be loaded as the optimization is not fully supported. https://www.tensorflow.org/lite/performance/post_training_quantization#dynamic_range_quantization * linter * linter * unit test fix
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* [TFLite] Added check for dynamic range quantization Added check to prevent optimized with "dynamic range quantization" tflite files to be loaded as the optimization is not fully supported. https://www.tensorflow.org/lite/performance/post_training_quantization#dynamic_range_quantization * linter * linter * unit test fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extra check to prevent optimized with "dynamic range quantization" tflite files to be loaded as this type of Tensorflow optimization is not fully supported in TVM (the optimization creates non-quantized command with quantized weights which cannot be correctly processed now).
https://www.tensorflow.org/lite/performance/post_training_quantization#dynamic_range_quantization