Skip to content

Made tensorflow IsNan actually work #7320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2021
Merged

Made tensorflow IsNan actually work #7320

merged 2 commits into from
Jan 21, 2021

Conversation

@jchia
Copy link
Contributor

@jchia jchia commented Jan 21, 2021

IsNan was added to tensorflow.rst in fa1b859 but this commit makes IsNan actually work

@jchia
Made tensorflow IsNan actually work
2132e80 
IsNan was added to tensorflow.rst in fa1b859 but this commit makes IsNan actually work
@leandron
Copy link
Contributor

leandron commented Jan 21, 2021

Thanks for the patch. Can you please add a test case for IsNan, to make sure it doesn't regress in future?

@jchia
Copy link
Contributor Author

jchia commented Jan 21, 2021 •
edited
Loading

Thanks for the patch. Can you please add a test case for IsNan, to make sure it doesn't regress in future?

I'm not familiar with the code base, but I think the test will be similar to test_forward_isinf() in tests/python/frontend/tensorflow/test_forward.py. Is that the right approach?

@leandron
Copy link
Contributor

leandron commented Jan 21, 2021

Thanks for the patch. Can you please add a test case for IsNan, to make sure it doesn't regress in future?

I'm not familiar with the code base, but I think the test will be similar to test_forward_isinf() in tests/python/frontend/tensorflow/test_forward.py. Is that the right approach?

cc @anijain2305 @siju-samuel @zhiics

siju-samuel
siju-samuel approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@siju-samuel siju-samuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen tqchen merged commit fc9e264 into apache:main Jan 21, 2021
@jchia jchia deleted the tf-isnan branch January 22, 2021 01:13
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 11, 2021
@jchia @alexwong
Made tensorflow IsNan actually work (apache#7320)
a5a6ecd 
* Made tensorflow IsNan actually work

IsNan was added to tensorflow.rst in fa1b859 but this commit makes IsNan actually work

* Added test case for tensorflow.is_nan
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
@jchia @electriclilies
Made tensorflow IsNan actually work (apache#7320)
aaa87bf 
* Made tensorflow IsNan actually work

IsNan was added to tensorflow.rst in fa1b859 but this commit makes IsNan actually work

* Added test case for tensorflow.is_nan
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
@jchia @Lokiiiiii
Made tensorflow IsNan actually work (apache#7320)
60c4400 
* Made tensorflow IsNan actually work

IsNan was added to tensorflow.rst in fa1b859 but this commit makes IsNan actually work

* Added test case for tensorflow.is_nan
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
@jchia @trevor-m
Made tensorflow IsNan actually work (apache#7320)
b3fd9e2 
* Made tensorflow IsNan actually work

IsNan was added to tensorflow.rst in fa1b859 but this commit makes IsNan actually work

* Added test case for tensorflow.is_nan
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandron leandron leandron approved these changes

@siju-samuel siju-samuel siju-samuel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jchia @leandron @siju-samuel @tqchen