[Relay][Topi] Add max mode to ROI align #7440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwfromm
approved these changes
Feb 12, 2021
Contributor
jwfromm
left a comment
jwfromm
left a comment
There was a problem hiding this comment.
I think there's a little code duplication that could be removed but otherwise this LGTM. Thanks Lily!
Contributor
Author
|
@junrushao1994 in case you want to take a look at adding inf, and ninf to hybridscript! |
Member
|
thanks @electriclilies! That part looks pretty good to me |
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* ROI align with max on cpu passes * onnx test file was not running gpu testsgit status! * all passing * fix lint * lint again * lint * lint * typo * remove import * fix import * add inf, -inf to hybridscript and respond to comments * shorten code * make atol lower
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* ROI align with max on cpu passes * onnx test file was not running gpu testsgit status! * all passing * fix lint * lint again * lint * lint * typo * remove import * fix import * add inf, -inf to hybridscript and respond to comments * shorten code * make atol lower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds max mode to ROI align.
The ONNX version of max mode in ROI align is incorrect (see microsoft/onnxruntime#6146), so I'm not testing ROI align with max mode against onnx's ROI align with max mode, even though I added max mode to the onnx importer.
I also add inf and -inf to hybridscript in this PR.
@jwfromm @mbrookhart @CircleSpin please take a look!