Skip to content

[ARITH] normalize iter affine map expr to PrimExpr #7759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 29, 2021
Merged

[ARITH] normalize iter affine map expr to PrimExpr #7759

merged 7 commits into from
Mar 29, 2021

Conversation

@spectrometerHBH
Copy link
Contributor

@spectrometerHBH spectrometerHBH commented Mar 27, 2021

cc @tqchen

@tqchen tqchen added the status: need test case need test cases to cover the change label Mar 27, 2021
@tqchen
Copy link
Member

tqchen commented Mar 27, 2021

Thanks @spectrometerHBH can you add a few testcases for normalize_iter_map_to_expr? Thank you!

@tqchen
Copy link
Member

tqchen commented Mar 27, 2021

cc @hzfan @Hzfengsy @jinhongyii

@tqchen tqchen self-assigned this Mar 27, 2021
@spectrometerHBH
Copy link
Contributor Author

spectrometerHBH commented Mar 28, 2021

The CI error looks wired to me. I don't know what leads to the error

@junrushao junrushao mentioned this pull request Mar 28, 2021
Closed
29 tasks
hzfan
hzfan approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@hzfan hzfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits

@tqchen tqchen added status: accepted and removed status: need review status: need test case need test cases to cover the change labels Mar 29, 2021
@tqchen tqchen merged commit af6f167 into apache:main Mar 29, 2021
@tqchen
Copy link
Member

tqchen commented Mar 29, 2021

Thanks @spectrometerHBH @jinhongyii @Hzfengsy @hzfan

@tqchen tqchen mentioned this pull request Mar 29, 2021
Merged
@junrushao junrushao linked an issue Mar 29, 2021 that may be closed by this pull request
[RFC][Tracking Issue] TensorIR Scheduling #7527
Closed
29 tasks
@spectrometerHBH spectrometerHBH deleted the iter-affine-map-convert branch March 30, 2021 00:26
@junrushao junrushao removed a link to an issue Apr 18, 2021
[RFC][Tracking Issue] TensorIR Scheduling #7527
Closed
29 tasks
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@spectrometerHBH
[ARITH] normalize iter affine map expr to PrimExpr (apache#7759)
7c8cb9c
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
@spectrometerHBH @trevor-m
[ARITH] normalize iter affine map expr to PrimExpr (apache#7759)
cbf84c3
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tqchen tqchen tqchen approved these changes

@Hzfengsy Hzfengsy Hzfengsy approved these changes

@jinhongyii jinhongyii jinhongyii approved these changes

+1 more reviewer

@hzfan hzfan hzfan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tqchen tqchen

Labels

status: accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spectrometerHBH @tqchen @hzfan @Hzfengsy @jinhongyii