[Target][Lowering] Update Op Intrinsic Lowering Mechanism And Intrinsic Lowering Pass #7809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Python side op lowering function has been changed from |
Member
|
Thanks for the contribution! A few high-level comments:
|
Member
Author
|
Thanks for the advice! I have changed the name of function in python-side to |
zxybazh
changed the title
Member
Author
|
@junrushao1994 Please review, thanks! |
junrushao
reviewed
Apr 16, 2021
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
junrushao
requested changes
Apr 16, 2021
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Please find some further comments :-)
junrushao
reviewed
Apr 16, 2021
Member
|
note, please do not checkin vta-hw submodule change(do a git submodule update) |
zxybazh
force-pushed
the
lower
branch
5 times, most recently
from
5521ac6 to
a04f2c2
Compare
junrushao
approved these changes
Apr 21, 2021
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
I don't have other comments :-) Thanks for the contribution!
Member
Member
|
@tqchen would you like to take a second look? If there is other comments, I will get it merged the other day |
tqchen
requested changes
Apr 22, 2021
Member
tqchen
left a comment
tqchen
left a comment
There was a problem hiding this comment.
two minor nits mainly on the api and use TypedPackedFunc over PackedFunc. Overall LGTM!
tqchen
requested changes
Apr 23, 2021
Member
tqchen
left a comment
tqchen
left a comment
There was a problem hiding this comment.
Thanks for keep improving the PR! Taking a close look this time. I think we can merge once the current set of comments are addressed
tqchen
approved these changes
Apr 23, 2021
Member
echuraev
pushed a commit
to echuraev/tvm
that referenced
this pull request
Apr 29, 2021
…ic Lowering Pass (apache#7809) This PR updated the intrinsic lowering pass to support the new op registry and avoid overloading the global tvm registry. Meanwhile, it kept the fallback mechanism to find the most suitable lower intrinsic function, e.g., llvm.FLowerIntrinsic vs. default.FLowerIntrinsic. All previous op registration are ported to new functions, and some missing ops would be added in separate PR.
umangyadav
pushed a commit
to umangyadav/tvm
that referenced
this pull request
May 5, 2021
…ic Lowering Pass (apache#7809) This PR updated the intrinsic lowering pass to support the new op registry and avoid overloading the global tvm registry. Meanwhile, it kept the fallback mechanism to find the most suitable lower intrinsic function, e.g., llvm.FLowerIntrinsic vs. default.FLowerIntrinsic. All previous op registration are ported to new functions, and some missing ops would be added in separate PR.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…ic Lowering Pass (apache#7809) This PR updated the intrinsic lowering pass to support the new op registry and avoid overloading the global tvm registry. Meanwhile, it kept the fallback mechanism to find the most suitable lower intrinsic function, e.g., llvm.FLowerIntrinsic vs. default.FLowerIntrinsic. All previous op registration are ported to new functions, and some missing ops would be added in separate PR.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…ic Lowering Pass (apache#7809) This PR updated the intrinsic lowering pass to support the new op registry and avoid overloading the global tvm registry. Meanwhile, it kept the fallback mechanism to find the most suitable lower intrinsic function, e.g., llvm.FLowerIntrinsic vs. default.FLowerIntrinsic. All previous op registration are ported to new functions, and some missing ops would be added in separate PR.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…ic Lowering Pass (apache#7809) This PR updated the intrinsic lowering pass to support the new op registry and avoid overloading the global tvm registry. Meanwhile, it kept the fallback mechanism to find the most suitable lower intrinsic function, e.g., llvm.FLowerIntrinsic vs. default.FLowerIntrinsic. All previous op registration are ported to new functions, and some missing ops would be added in separate PR.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…ic Lowering Pass (apache#7809) This PR updated the intrinsic lowering pass to support the new op registry and avoid overloading the global tvm registry. Meanwhile, it kept the fallback mechanism to find the most suitable lower intrinsic function, e.g., llvm.FLowerIntrinsic vs. default.FLowerIntrinsic. All previous op registration are ported to new functions, and some missing ops would be added in separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updated the intrinsic lowering pass to support the new op registry and avoid overloading the global tvm registry. Meanwhile, it kept the fallback mechanism to find the most suitable lower intrinsic function, e.g.,
llvm.FLowerIntrinsicvs.default.FLowerIntrinsic. All previous op registration are ported to new functions, and some missing ops would be added in separate PR.