[CuDNN] Remove GPU dependency from tvm.contrib.cudnn.conv_output_shape #8275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the local server couldn't initialize a CuDNN-enabled GPU, it couldn't generate code that uses CuDNN's forward conv. This commit adds a python implementation of conv_output_shape, along with tests to verify that the outputs are matched to CuDNN's output.
Contributor
Author
|
Related PR #8276 is for the same goal of allowing CuDNN modules to be build on a local non-GPU machine for use on a remote GPU machine. The two implementations are independent, and are separate PRs for reviewing purposes. Potential reviewer: @mdw-octoml |
jwfromm
approved these changes
Jun 17, 2021
Contributor
jwfromm
left a comment
jwfromm
left a comment
There was a problem hiding this comment.
Excellent change, thanks!
Contributor
|
@icemelon9 it'd be great if you could take a look at this PR and make sure you agree with the change. |
mdw-octoml
approved these changes
Jun 18, 2021
Contributor
mdw-octoml
left a comment
mdw-octoml
left a comment
There was a problem hiding this comment.
LGTM, thank you Eric!
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
apache#8275) Previously, if the local server couldn't initialize a CuDNN-enabled GPU, it couldn't generate code that uses CuDNN's forward conv. This commit adds a python implementation of conv_output_shape, along with tests to verify that the outputs are matched to CuDNN's output. Co-authored-by: Eric Lunderberg <[email protected]>
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
apache#8275) Previously, if the local server couldn't initialize a CuDNN-enabled GPU, it couldn't generate code that uses CuDNN's forward conv. This commit adds a python implementation of conv_output_shape, along with tests to verify that the outputs are matched to CuDNN's output. Co-authored-by: Eric Lunderberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the local server couldn't initialize a CuDNN-enabled
GPU, it couldn't generate code that uses CuDNN's forward conv. This
commit adds a python implementation of conv_output_shape, along with
tests to verify that the outputs are matched to CuDNN's output.