[Frontend][Tensorflow2] Stridedslice and concat_v2 fix #8483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinidhigoud
changed the title
Contributor
Author
trevor-m
approved these changes
Jul 15, 2021
Contributor
trevor-m
left a comment
trevor-m
left a comment
There was a problem hiding this comment.
Changes look good to me. Is it possible to add a unit test for the ConcatV2 fix?
srinidhigoud
force-pushed
the
stridedslice-fix
branch
from
d3f3aa3 to
22b26ac
Compare
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* fix for strided_slice when begin > end in case of shrinkaxis_mask * fix for name_hint missing error for concat_v2 op * removing a local fix * adding more testing capability to concat_v2
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
* fix for strided_slice when begin > end in case of shrinkaxis_mask * fix for name_hint missing error for concat_v2 op * removing a local fix * adding more testing capability to concat_v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strided_slice: In case of shrink axis, we need slice of a length one. And the slicing should start from m_begin[final_index]. So this change corrects it accordingly
concat_v2: This fix handles when there is an attribute error in the op