[TFLite] Mimic the TFLite 2.4 reader's behaviour #8538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In TFLite 2.4, the builtin code value can be either in "deprecated_builtin_code" field or "builtin_code" field (as long as the value is less than 127) and similarly to the TFLite's reader, we should use the higher value of the two. Change-Id: I0d738f9257187903b4c5b4cc5a8733a451ddc02e
ekalda
requested review from
Huyuwei,
jwfromm,
kazum,
mbrookhart,
siju-samuel and
srkreddy1238
as code owners
Contributor
Author
|
That's how TFLite's reader does it - https://github.com/tensorflow/tensorflow/blob/7d2f189d314018722ea801293de102480c8fbc62/tensorflow/lite/schema/schema_utils.cc |
Contributor
Author
|
I see - this allows us to consume models produced by old writers and new writers which may or may not set the fields correctly. LGTM, |
u99127
approved these changes
Jul 23, 2021
Contributor
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
In TFLite 2.4, the builtin code value can be either in "deprecated_builtin_code" field or "builtin_code" field (as long as the value is less than 127) and similarly to the TFLite's reader, we should use the higher value of the two. Change-Id: I0d738f9257187903b4c5b4cc5a8733a451ddc02e
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
In TFLite 2.4, the builtin code value can be either in "deprecated_builtin_code" field or "builtin_code" field (as long as the value is less than 127) and similarly to the TFLite's reader, we should use the higher value of the two. Change-Id: I0d738f9257187903b4c5b4cc5a8733a451ddc02e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TFLite 2.4, the builtin code value can be either in
"deprecated_builtin_code" field or "builtin_code" field (as long
as the value is less than 127) and similarly to the TFLite's
reader, we should use the higher value of the two.