[RELAY] [AST] Add virtual_device as a first class field in Relay #9641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electriclilies
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
electriclilies
changed the title
mbs-octoml
approved these changes
Dec 2, 2021
Contributor
mbs-octoml
left a comment
mbs-octoml
left a comment
There was a problem hiding this comment.
Thanks Lily, this can't come soon enough as I spent yesterday tracking down more accidentally-lost on_device annotations!
electriclilies
force-pushed
the
first-class-scope
branch
from
fa8466d to
0fe8291
Compare
Contributor
Author
|
@comaniac Could you take a look at this? It's my implementation of apache/tvm-rfcs#45. Thanks! |
comaniac
reviewed
Dec 7, 2021
Contributor
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
Overall LGTM. Just some docstring errors.
electriclilies
force-pushed
the
first-class-scope
branch
2 times, most recently
from
fa8466d to
1637380
Compare
Contributor
Author
|
@comaniac Thanks, updated the comments and docstrings! I think this is good to go in once CI is green. |
Member
|
THanks @electriclilies for the contribution. Thanks @comaniac @mbs-octoml for reviewing. This PR is now merged |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds virtual_device (SEScope) as a first class field in Relay. This is an implementation of apache/tvm-rfcs#45 please take a look the RFC for the motivation, implementation, future work, etc.
@mbs-octoml @jroesch @mikepapadim