Change function constructors to WithFields #9690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electriclilies
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
manupak,
mbaret,
mbrookhart,
slyubomirsky,
trevor-m,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Contributor
Author
|
i split these out from another branch, there are still some residual changes from that branch that I need to revert. |
electriclilies
force-pushed
the
with_fields_functions
branch
from
d159c4d to
b6f5805
Compare
electriclilies
force-pushed
the
with_fields_functions
branch
from
f2f166c to
31513f5
Compare
Contributor
Author
|
This is ready for review, please take a look @mbs-octoml @mikepapadim. |
electriclilies
force-pushed
the
with_fields_functions
branch
2 times, most recently
from
f48ae84 to
ff0082d
Compare
electriclilies
force-pushed
the
with_fields_functions
branch
from
625a301 to
bfbd03f
Compare
electriclilies
force-pushed
the
with_fields_functions
branch
2 times, most recently
from
8785d19 to
6001b53
Compare
mbs-octoml
approved these changes
Jan 12, 2022
Contributor
mbs-octoml
left a comment
mbs-octoml
left a comment
There was a problem hiding this comment.
Thanks Lily! Just two minor changes asking to retain the existing shallow copies. I think this still needs to be rebased but no mind.
electriclilies
force-pushed
the
with_fields_functions
branch
5 times, most recently
from
49ca379 to
5f4d9ff
Compare
electriclilies
force-pushed
the
with_fields_functions
branch
from
3ec58ff to
ecf41ad
Compare
Get rid of std::moves, they were causing problems
electriclilies
force-pushed
the
with_fields_functions
branch
from
78e76cd to
9bcd271
Compare
jroesch
approved these changes
Jan 26, 2022
sunggg
pushed a commit
to sunggg/tvm
that referenced
this pull request
Jan 29, 2022
* Change function constructors to WithFields Get rid of std::moves, they were causing problems * Fix bad rebase * flaky * try to trigger ci * try again
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* Change function constructors to WithFields Get rid of std::moves, they were causing problems * Fix bad rebase * flaky * try to trigger ci * try again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I change function constructors to WithFields. I tried to change all of them but may have missed a few.