[Hexagon] Detect link-params via IRModule instead of target attribute #9695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, restore the construction of target attributes in the Hexagon target. This was erroneously removed in PR#9352. That PR deprecated target attributes, but also added transferring these attributes to the new mechanism. Removing the attributes from tvm.target.hexagon eliminated them completely. Restoring the target attributes allow time to transition TVM clients to the new mechanisms.
kparzysz-quic
requested review from
ZihengJiang,
junrushao,
masahi,
tqchen and
vinx13
as code owners
jroesch
approved these changes
Dec 10, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…apache#9695) Additionally, restore the construction of target attributes in the Hexagon target. This was erroneously removed in PR#9352. That PR deprecated target attributes, but also added transferring these attributes to the new mechanism. Removing the attributes from tvm.target.hexagon eliminated them completely. Restoring the target attributes allow time to transition TVM clients to the new mechanisms.
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
…apache#9695) Additionally, restore the construction of target attributes in the Hexagon target. This was erroneously removed in PR#9352. That PR deprecated target attributes, but also added transferring these attributes to the new mechanism. Removing the attributes from tvm.target.hexagon eliminated them completely. Restoring the target attributes allow time to transition TVM clients to the new mechanisms.
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
…apache#9695) Additionally, restore the construction of target attributes in the Hexagon target. This was erroneously removed in PR#9352. That PR deprecated target attributes, but also added transferring these attributes to the new mechanism. Removing the attributes from tvm.target.hexagon eliminated them completely. Restoring the target attributes allow time to transition TVM clients to the new mechanisms.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…apache#9695) Additionally, restore the construction of target attributes in the Hexagon target. This was erroneously removed in PR#9352. That PR deprecated target attributes, but also added transferring these attributes to the new mechanism. Removing the attributes from tvm.target.hexagon eliminated them completely. Restoring the target attributes allow time to transition TVM clients to the new mechanisms.
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
…apache#9695) Additionally, restore the construction of target attributes in the Hexagon target. This was erroneously removed in PR#9352. That PR deprecated target attributes, but also added transferring these attributes to the new mechanism. Removing the attributes from tvm.target.hexagon eliminated them completely. Restoring the target attributes allow time to transition TVM clients to the new mechanisms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, restore the construction of target attributes in the Hexagon target. This was erroneously removed in PR#9352.
That PR deprecated target attributes, but also added transferring these attributes to the new mechanism. Removing the attributes from
tvm.target.hexagoneliminated them completely. Restoring the target attributes allow time to transition TVM clients to the new mechanisms.