[Runtime][Pipeline executor] Global parameters group name and runtime modules parameters map. #9846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huajsj
requested review from
ZihengJiang,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
kazum,
liangfu,
masahi,
merrymercy,
tmoreau89,
tqchen,
vinx13,
yzhliu and
zhiics
as code owners
15 tasks
Contributor
Author
comaniac
requested changes
Jan 13, 2022
modules parameters map. Solution: To support on the fly parameters setting for each runtime module in pipeline executor, we create a feature that use global parameters group name to map the runtime module parameter, after such map relation get created user can do the on the fly parameters setting by using the parameters group name. trigger build. fix ut issue. polish comments. Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update src/runtime/pipeline/pipeline_executor.h Co-authored-by: Cody Yu <[email protected]> Update src/runtime/pipeline/pipeline_struct.h Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> address review comments.
comaniac
reviewed
Jan 13, 2022
Co-authored-by: Cody Yu <[email protected]>
comaniac
approved these changes
Jan 13, 2022
yuanfz98
pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
… modules parameters map. (apache#9846) * [Runtime][Pipeline executor] Global parameters group name and runtime modules parameters map. Solution: To support on the fly parameters setting for each runtime module in pipeline executor, we create a feature that use global parameters group name to map the runtime module parameter, after such map relation get created user can do the on the fly parameters setting by using the parameters group name. trigger build. fix ut issue. polish comments. Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update src/runtime/pipeline/pipeline_executor.h Co-authored-by: Cody Yu <[email protected]> Update src/runtime/pipeline/pipeline_struct.h Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> address review comments. * Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> * fix plint issue. Co-authored-by: Cody Yu <[email protected]>
crazydemo
pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
… modules parameters map. (apache#9846) * [Runtime][Pipeline executor] Global parameters group name and runtime modules parameters map. Solution: To support on the fly parameters setting for each runtime module in pipeline executor, we create a feature that use global parameters group name to map the runtime module parameter, after such map relation get created user can do the on the fly parameters setting by using the parameters group name. trigger build. fix ut issue. polish comments. Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update src/runtime/pipeline/pipeline_executor.h Co-authored-by: Cody Yu <[email protected]> Update src/runtime/pipeline/pipeline_struct.h Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> address review comments. * Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> * fix plint issue. Co-authored-by: Cody Yu <[email protected]>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
… modules parameters map. (apache#9846) * [Runtime][Pipeline executor] Global parameters group name and runtime modules parameters map. Solution: To support on the fly parameters setting for each runtime module in pipeline executor, we create a feature that use global parameters group name to map the runtime module parameter, after such map relation get created user can do the on the fly parameters setting by using the parameters group name. trigger build. fix ut issue. polish comments. Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> Update src/runtime/pipeline/pipeline_executor.h Co-authored-by: Cody Yu <[email protected]> Update src/runtime/pipeline/pipeline_struct.h Co-authored-by: Cody Yu <[email protected]> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> address review comments. * Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <[email protected]> * fix plint issue. Co-authored-by: Cody Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
To support on the fly parameters setting for each runtime module in pipeline executor, we create a feature that use global parameters group name to map the runtime module parameter, after such map relation get created user can do the on the fly parameters setting by using the parameters group name.