Skip to content

[TIR][Schedule] Blockize and Tensorize #9871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 26, 2022
Merged

[TIR][Schedule] Blockize and Tensorize #9871

merged 20 commits into from
Jan 26, 2022

Conversation

@vinx13
Copy link
Member

@vinx13 vinx13 commented Jan 7, 2022 •
edited
Loading

This PR added two schedule primitives, blockize, and tensorize to TensorIR.

cc @junrushao1994 @spectrometerHBH @Hzfengsy @masahi @comaniac @tqchen @csullivan

Co-authored-by: Siyuan Feng [email protected]
Co-authored-by: Bohan Hou [email protected]
Co-authored-by: Hongyi Jin [email protected]
Co-authored-by: Ruihang Lai [email protected]
Co-authored-by: Junru Shao [email protected]
Co-authored-by: Xiyou Zhou [email protected]

@vinx13 vinx13 force-pushed the feat/blockize branch 2 times, most recently from 36e6ed0 to 5a31897 Compare January 7, 2022 22:56
junrushao
junrushao reviewed Jan 7, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 7, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 7, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 7, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 7, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 7, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 7, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 7, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 7, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 7, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 8, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 8, 2022
View reviewed changes
src/tir/schedule/state.cc Outdated
Comment on lines 204 to 205
self_->block_info[scope_root] = BlockInfo(BlockScope(child_block_srefs));
BlockInfo& info = self_->block_info[scope_root];
Copy link
Member

@junrushao junrushao Jan 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? I suppose they are logically equivalent and the original one saves one lookup?

Copy link
Member Author

@vinx13 vinx13 Jan 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emplace will not overwrite the old entry if the key exists. This function may be called in UpdateScopeBlockInfo

Copy link
Member

@junrushao junrushao Jan 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see - that makes sense to me! Then to save one look-up, let's do

Suggested change
self_->block_info[scope_root] = BlockInfo(BlockScope(child_block_srefs));
BlockInfo& info = self_->block_info[scope_root];
BlockInfo& info = self_->block_info[scope_root] = BlockInfo(BlockScope(child_block_srefs));

junrushao
junrushao reviewed Jan 8, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 8, 2022
View reviewed changes
junrushao
junrushao reviewed Jan 8, 2022
View reviewed changes
Hzfengsy
Hzfengsy requested changes Jan 8, 2022
View reviewed changes
src/tir/schedule/analysis.h Outdated
bool CompareRange(const Range& lhs, const Range& rhs);
bool CompareType(const DataType& lhs, const DataType& rhs);

protected:
Copy link
Member

@Hzfengsy Hzfengsy Jan 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why protected?

Copy link
Member Author

@vinx13 vinx13 Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there might be some use cases to subclass this class, like auto tensorization

src/tir/schedule/analysis/analysis.cc Outdated
if (n->type_index() != other->type_index()) return false;
bool equal = StmtComparator::VisitStmt(n, other);
if (!equal && assert_mode_)
LOG(FATAL) << "Stmts are not matching between:\n" << n << "\nand\n" << other;
Copy link
Member

@Hzfengsy Hzfengsy Jan 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use ScheduleError here? Since it has a better error renderer

Copy link
Member

@junrushao junrushao Jan 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it's non-trivial for now to do so, let's leave it as future improvement

junrushao
junrushao approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all my comments (a lot) are addressed. Thanks for the effort @vinx13!

@github-actions github-actions bot requested a review from junrushao January 25, 2022 01:46
MasterJH5574
MasterJH5574 reviewed Jan 25, 2022
View reviewed changes
@Hzfengsy Hzfengsy merged commit 5e7438f into apache:main Jan 26, 2022
@junrushao junrushao mentioned this pull request Jan 26, 2022
Closed
62 tasks
sunggg pushed a commit to sunggg/tvm that referenced this pull request Jan 29, 2022
@vinx13 @spectrometerHBH
@jinhongyii @MasterJH5574 @junrushao @zxybazh @sunggg
[TIR][Schedule] Blockize and Tensorize (apache#9871)
f9e1ff8 
* WIP

* WIP

* WIP

* test cases

* add examples

* lint

* Amend co-authors information

Co-authored-by: Siyuan Feng <[email protected]>
Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Hongyi Jin <[email protected]>
Co-authored-by: Ruihang Lai <[email protected]>
Co-authored-by: Junru Shao <[email protected]>
Co-authored-by: Xiyou Zhou <[email protected]>

* WIP

* address comments and changed tensorized comparator

* update

* nit

* fix example

* lint

* lint

* lint

* remove unused

* trigger ci

* clang-format

* fix

* rebase

Co-authored-by: Siyuan Feng <[email protected]>
Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Hongyi Jin <[email protected]>
Co-authored-by: Ruihang Lai <[email protected]>
Co-authored-by: Junru Shao <[email protected]>
Co-authored-by: Xiyou Zhou <[email protected]>
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
@vinx13 @spectrometerHBH
@jinhongyii @MasterJH5574 @junrushao @zxybazh @ylc
[TIR][Schedule] Blockize and Tensorize (apache#9871)
55a36ea 
* WIP

* WIP

* WIP

* test cases

* add examples

* lint

* Amend co-authors information

Co-authored-by: Siyuan Feng <[email protected]>
Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Hongyi Jin <[email protected]>
Co-authored-by: Ruihang Lai <[email protected]>
Co-authored-by: Junru Shao <[email protected]>
Co-authored-by: Xiyou Zhou <[email protected]>

* WIP

* address comments and changed tensorized comparator

* update

* nit

* fix example

* lint

* lint

* lint

* remove unused

* trigger ci

* clang-format

* fix

* rebase

Co-authored-by: Siyuan Feng <[email protected]>
Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Hongyi Jin <[email protected]>
Co-authored-by: Ruihang Lai <[email protected]>
Co-authored-by: Junru Shao <[email protected]>
Co-authored-by: Xiyou Zhou <[email protected]>
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wrongtest-intellif wrongtest-intellif wrongtest-intellif left review comments

@MasterJH5574 MasterJH5574 MasterJH5574 left review comments

@Hzfengsy Hzfengsy Hzfengsy approved these changes

@areusch areusch Awaiting requested review from areusch

@comaniac comaniac Awaiting requested review from comaniac

@icemelon icemelon Awaiting requested review from icemelon

@jroesch jroesch Awaiting requested review from jroesch

@kparzysz-quic kparzysz-quic Awaiting requested review from kparzysz-quic

@masahi masahi Awaiting requested review from masahi

@merrymercy merrymercy Awaiting requested review from merrymercy

@tqchen tqchen Awaiting requested review from tqchen

@yzhliu yzhliu Awaiting requested review from yzhliu

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang

@spectrometerHBH spectrometerHBH Awaiting requested review from spectrometerHBH

@junrushao junrushao Awaiting requested review from junrushao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vinx13 @wrongtest-intellif @xqdan @junrushao @driazati @Hzfengsy @MasterJH5574