Skip to content

Fix encoding webhook lists in request parameters #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2023
Merged

Fix encoding webhook lists in request parameters #126

merged 1 commit into from
May 31, 2023

Conversation

@fnesveda
Copy link
Member

@fnesveda fnesveda commented May 31, 2023

Webhooks could not be parsed on the API when sent base64-encoded as bytes, they need to be sent as string.

@fnesveda fnesveda added bug Something isn't working. adhoc Ad-hoc unplanned task added during the sprint. t-core-services Issues with this label are in the ownership of the core services team. labels May 31, 2023
@fnesveda fnesveda added this to the 64th sprint - Platform team milestone May 31, 2023
@fnesveda fnesveda requested review from drobnikj and jirimoravcik May 31, 2023 12:53
@fnesveda fnesveda self-assigned this May 31, 2023
jirimoravcik
jirimoravcik approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@jirimoravcik jirimoravcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@fnesveda fnesveda merged commit f1c69f2 into master May 31, 2023
@fnesveda fnesveda deleted the fix/fix-encoding-webhooks branch May 31, 2023 13:10
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jirimoravcik jirimoravcik jirimoravcik approved these changes

@drobnikj drobnikj Awaiting requested review from drobnikj

Assignees

@fnesveda fnesveda

Labels

adhoc Ad-hoc unplanned task added during the sprint. bug Something isn't working. t-core-services Issues with this label are in the ownership of the core services team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Projects

None yet

Milestone

64th sprint - Platform team

Development

Successfully merging this pull request may close these issues.

3 participants

@fnesveda @jirimoravcik