refactor!: Replace httpx HTTP client with impit
#456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The errors in the tests are caused by issues with I expect them to be resolved with apify/impit#234 When testing locally on a build with this fix, the errors do not reproduce. |
vdusek
changed the title
httpx http-clients with impithttpx http-clients with impit
vdusek
changed the title
httpx http-clients with impithttpx http-clients with impit
Contributor
|
We consider this as BC, and I don't think it is a feature, so I updated the title type to |
Mantisus
had a problem deploying
to
fork-pr-integration-tests
GitHub Actions
Failure
Mantisus
requested review from
Pijukatel and
vdusek
and removed request for
Pijukatel
vdusek
requested changes
Aug 12, 2025
Contributor
There was a problem hiding this comment.
Could you also please describe the BCs in the upgrading guide? Similar to what we have in Crawlee and SDK, see e.g. https://crawlee.dev/python/docs/upgrading/upgrading-to-v1.
Otherwise it looks great!
vdusek
changed the title
httpx http-clients with impithttpx HTTP client with impit
Mantisus
had a problem deploying
to
fork-pr-integration-tests
GitHub Actions
Failure
Mantisus
had a problem deploying
to
fork-pr-integration-tests
GitHub Actions
Failure
Mantisus
had a problem deploying
to
fork-pr-integration-tests
GitHub Actions
Failure
Pijukatel
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpxhttp-clients withimpit